Auto merge of #168 - DexterHaslem:add-compiletest-dir-check, r=jdm

also check 'compiletest/plugin/compile-fail' test dir on a new PR This addresses issue #167 - Let me know if you'd rather not slam the entire sub-dir path in `TEST_DIRS_TO_CHECK` and instead do something like COMPILE_TEST_DIRS_TO_CHECK
servo · Jan 27, 2017 · 3b829f4 · 3b829f4
2 parents 3c826df + 770e95b
commit 3b829f4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/handlers/missing_test/__init__.py b/handlers/missing_test/__init__.py
@@ -8,7 +8,8 @@
 
 class MissingTestHandler(EventHandler):
     COMPONENT_DIRS_TO_CHECK = ('layout', 'script', 'gfx', 'style', 'net')
-    TEST_DIRS_TO_CHECK = ('ref', 'wpt', 'unit')
+    TEST_DIRS_TO_CHECK = ('ref', 'wpt', 'unit',
+                          'compiletest/plugin/compile-fail')
     TEST_FILES_TO_CHECK = [
         '{0}/{1}'.format('components/script/dom', test_file)
         for test_file in ['testbinding.rs',

diff --git a/handlers/missing_test/tests/new_pr.json b/handlers/missing_test/tests/new_pr.json
@@ -27,6 +27,9 @@
     {
       "comments": 0
     }, 
+    {
+      "comments": 0
+    },
     {
       "comments": 0
     }
@@ -61,6 +64,9 @@
     }, 
     {
       "diff": "diff --git components/script/\ndiff --git tests/unit"
+    }, 
+    {
+      "diff": "diff --git components/script/\ndiff --git tests/compiletest/plugin/compile-fail"
     }
   ], 
   "payload": {