Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if compile-fail tests are modified #167

Closed
jdm opened this issue Jan 22, 2017 · 4 comments
Closed

Check if compile-fail tests are modified #167

jdm opened this issue Jan 22, 2017 · 4 comments
Labels
C-Assigned E-Easy

Comments

@jdm
Copy link
Member

jdm commented Jan 22, 2017

Our missing_tests handler warns if changes are made to Servo without corresponding automated tests. Sometimes we get false positives like servo/servo#15146 because the compile-fail directory is not checked right now. We should fix this and add an automated test to tests/new_pr.json.
@jdm jdm added the E-Easy label Jan 22, 2017
@highfive
Copy link
Collaborator

Please make a comment here if you intend to work on this issue. Thank you!

@DexterHaslem
Copy link
Contributor

I'd like to work on this

@jdm
Copy link
Member Author

jdm commented Jan 24, 2017

Please do! Ask questions if anything is unclear :)

@jdm jdm added the C-Assigned label Jan 24, 2017
@DexterHaslem DexterHaslem mentioned this issue Jan 25, 2017
Merged
bors-servo pushed a commit that referenced this issue Jan 27, 2017
Auto merge of #168 - DexterHaslem:add-compiletest-dir-check, r=jdm
3b829f4 
also check 'compiletest/plugin/compile-fail' test dir on a new PR

This addresses issue #167 - Let me know if you'd rather not slam the entire sub-dir path in `TEST_DIRS_TO_CHECK` and instead do something like COMPILE_TEST_DIRS_TO_CHECK
@jdm
Copy link
Member Author

jdm commented Feb 3, 2017

Fixed by #168.

@jdm jdm closed this as completed Feb 3, 2017
Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
@alexcrichton
Merge pull request servo#167 from rust-lang-nursery/nikomatsakis-patch-4
a7958c7 
add zackmdavis to the hi5 list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Assigned E-Easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdm @DexterHaslem @highfive