Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an I-issue-report label to issue reports #144

Open
asajeffrey opened this issue Jul 1, 2016 · 8 comments
Open

Add an I-issue-report label to issue reports #144

asajeffrey opened this issue Jul 1, 2016 · 8 comments

Comments

@asajeffrey
Copy link
Member

browserhtml/browserhtml#1152 adds an identifying string This report was generated by the browser.html issue reporter. to issue reports it generates. Highfive could use this information, for example to add an I-issue-report label to the issue.

@highfive
Copy link
Collaborator

highfive commented Jul 1, 2016

Please make a comment here if you intend to work on this issue. Thank you!

@highfive
Copy link
Collaborator

highfive commented Jul 1, 2016

cc @jdm

@asajeffrey
Copy link
Member Author

Over in IRC (http://logs.glob.uno/?c=mozilla%23servo&s=1+Jul+2016&e=1+Jul+2016#c470789) @aneeshusa says this should be E-Easy.

@jdm
Copy link
Member

jdm commented Jul 1, 2016

This belongs in a new handler in handlers which looks at the body of the issue and adds the label if necessary.

@cbrewster
Copy link
Contributor

Should we also add the I-panic tag? As these issue reports are only generated when a panic occurs?

@jdm
Copy link
Member

jdm commented Jul 1, 2016

This will be a bit more work than originally anticipated, because we don't have any handlers that deal with opening new issues. We'll want to make the created event map to either on_new_pr or on_new_issue based on whether the pull_request field exists in the payload['issue'] object (see eventhandler.py).

@jdm
Copy link
Member

jdm commented Jul 1, 2016

Yes, adding the panic tag would also be useful.

@asajeffrey
Copy link
Member Author

At some point we may be getting error reports that aren't panics, but we can cross that bridge when we come to it.

@asajeffrey asajeffrey removed the E-Easy label Jul 2, 2016
Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants