Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help people without permissions claim issues #30

Open
edunham opened this issue Nov 23, 2015 · 5 comments
Open

Help people without permissions claim issues #30

edunham opened this issue Nov 23, 2015 · 5 comments

Comments

@edunham
Copy link
Contributor

edunham commented Nov 23, 2015

Servo has the wonderful problem of new contributors stepping on each others' toes for introductory bugs. To reduce this, it would be nice to have Highfive note that an issue is claimed when someone claims it. I can think of two ways to implement an "assign to newbie":

Either way, I'd propose a syntax like "@highfive assign @username" (usable by people with r+ perms on the repo to assign to arbitrary newbies) plus "@highfive assign me" for someone who has no perms yet to claim the ticket through whichever mechanic we decide.

It could also be nice to have the issue-claiming syntax include a timeout, like "@highfive assign me 1week", and have highfive unassign the issue if it ever sits for longer than the specified timeout with no new comments.

@jdm, thoughts?

@jdm
Copy link
Member

jdm commented Nov 23, 2015

The timeout idea would require some notion of state to be preserved, as well as figuring out when and how to trigger highfive to deal with expired items, since it's only run as a webhook at the moment. Here's a way we could make the special assignment syntax maximally useful:

  • when an issue marked "E-easy" or "E-less easy" receives a comment from a user who is not in the list of repository contributors
  • if it is the user's first comment in the issue
  • we could have highfive add a comment saying something like "Hi [username]! I'm an automated bot to help new contributors; if you're asking to have this issue assigned to you, just say "@highfive assign me" and I'll make it happen!"
    This would hopefully act as a useful learning device without being an annoyance.

@edunham
Copy link
Contributor Author

edunham commented Nov 23, 2015

Heard back from github support:

To answer your question, you must have at least Read permission on a repository to be assigned an issue

so the teams implementation could work for this.

@jdm
Copy link
Member

jdm commented Nov 23, 2015

That's a very interesting solution!

@perlun
Copy link

perlun commented Jun 22, 2016

I think the idea of adding people who are helping out in various small ways to a read-only team makes sense. It makes it possible to properly assign issues to people, which is a great benefit. The administrative burden of doing this should also be fairly low.

@edunham
Copy link
Contributor Author

edunham commented Aug 25, 2016

Today I learned about https://github.com/eeyorebot/eeyore, which might have the features to address this issue.

Mark-Simulacrum pushed a commit to Mark-Simulacrum/highfive that referenced this issue Sep 8, 2020
If the optional "dir" field is a non-empty dict mapping directory names
to a list of groups/users, examine the diff to find the directory under
src/ with the most changes and add the groups/users associated with that
directory.

Closes servo#30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants