unescape HTML entities in test failure output #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon. |
|
Heads up! This PR modifies the following files:
|
|
Is there a way to test these changes? |
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| import json | |||
| import re | |||
| import HTMLParser | |||
There was a problem hiding this comment.
This could just be from HTMLParser import HTMLParser and it could be moved to the previous group.
|
@KiChjang The current design of highfive's testsuite only checks the number of comments for a particular handler at the end of each test, not the contents they have (I'm planning to implement it someday soon). |
|
@KiChjang I'm not sure. The existing test only checks for the presence of a comment. |
|
Squash the commits and we'll be good to go! |
|
Thanks for doing this work! :) |
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/highfive
that referenced
this pull request
Sep 8, 2020
Adding Rust Code of Conduct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #94