Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if self.token is present #177

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Check if self.token is present #177

merged 1 commit into from
Apr 24, 2017

Conversation

Sriharivignesh
Copy link
Contributor

Instead of checking if token is present in which case Python searches for a global variable named 'token' and errors out.

@highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon.

@highfive
Copy link
Collaborator

Heads up! This PR modifies the following files:

@jdm
Copy link
Member

jdm commented Apr 24, 2017

@bors-servo: r+
Weird! Thanks for the fix!

@bors-servo
Copy link

📌 Commit 6a3a1a6 has been approved by jdm

@bors-servo
Copy link

⌛ Testing commit 6a3a1a6 with merge 5a21c88...

bors-servo pushed a commit that referenced this pull request Apr 24, 2017
Check if self.token is present

Instead of checking if token is present in which case Python searches for a global variable named 'token' and errors out.
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: jdm
Pushing 5a21c88 to master...

@bors-servo bors-servo merged commit 6a3a1a6 into servo:master Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants