Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @ optional in "r? username" comments #188

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Make @ optional in "r? username" comments #188

merged 1 commit into from
Aug 29, 2017

Conversation

mbrubeck
Copy link
Contributor

This allows PR descriptions to include instructions like "r? mbrubeck" without sending extraneous email when the PR is merged to other repos.

This allows PR descriptions to include instructions like "r? mbrubeck" without sending extraneous email when the PR is merged to other repos.
@ghost ghost assigned jdm Aug 29, 2017
@ghost
Copy link

ghost commented Aug 29, 2017

@jdm Please review this pull request (or r? @someone and I'll assign it to them). Thanks.

@ghost ghost added the S-awaiting-review label Aug 29, 2017
@nox
Copy link

nox commented Aug 29, 2017

I'm almost tempted to use the emoji reaction feature to celebrate.

@bors-servo r+

@bors-servo
Copy link

📌 Commit 3ae66d8 has been approved by nox

@bors-servo
Copy link

⌛ Testing commit 3ae66d8 with merge 52cc8e6...

bors-servo pushed a commit that referenced this pull request Aug 29, 2017
Make @ optional in "r? username" comments

This allows PR descriptions to include instructions like "r? mbrubeck" without sending extraneous email when the PR is merged to other repos.
@ghost ghost assigned nox Aug 29, 2017
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: nox
Pushing 52cc8e6 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants