This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Add buildbot 0.9 support steps in README.md #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atouchet
reviewed
May 18, 2017
README.md
Outdated
| - Buildbot 0.9 via GithubStatusPush | ||
|
|
||
| Buildbot 0.9 support [GithubStatusPush](http://docs.buildbot.net/latest/manual/cfg-reporters.html#githubstatuspush), | ||
| so we can use this to integrate with Github and Buildbot 0.9. |
There was a problem hiding this comment.
The "H" in GitHubStatusPush and GitHub should be capitalized.
There are a few more instances of these below as well.
|
@atouchet I have fixed that. |
|
@coldnight "GithubStatusPush" still needs to be fixed. |
|
@atouchet Sorry I miss that. Now that was fixed. |
|
(note: won't have time to review this for a few weeks) |
|
☔ The latest upstream changes (presumably #117) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same propose with #115 but in different way.
Inspired by this comment
I have tried in my own project, and it works. So I add the steps into
README.md.
This change is