This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Quick fix for homu timeout on try (fixes #903) #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit 755c02c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 15, 2018
Quick fix for homu timeout on try (fixes #903) Homu unconditionally waits on non-buildbot builders on a try build, which is fine except on a try_choose build it shouldn't. The proper fix is to break `try` support out of the buildbot code here so that try choosers can be status builders too, which I'll do sometime later. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/174) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homu unconditionally waits on non-buildbot builders on a try build, which is fine except on a try_choose build it shouldn't.
The proper fix is to break
trysupport out of the buildbot code here so that try choosers can be status builders too, which I'll do sometime later.r? @jdm
This change is