Move code generation into an integration test #472
+4,159
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping? |
|
☔ The latest upstream changes (presumably #481) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Another ping... @nox did you want to take a look? |
|
☔ The latest upstream changes (presumably #491) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@jdm if I rebase this, will you review it? |
djc
force-pushed
the
test-codegen
branch
2 times, most recently
from
57d678d
to
c814231
Compare
|
Rebased. |
|
@jdm since you seem to be paying attention -- got an opinion on this? |
djc
force-pushed
the
test-codegen
branch
3 times, most recently
from
1f5203a
to
d10dc22
Compare
|
One other reason I prefer this approach is that the generated code becomes much more legible (for example, via the IDE). I was trying to clean up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the generated code only depends on files in the repository anyway, save the separate compilation for the build script and only generate code in a test. Make it fail if the generated code is different from the stored source code to make CI fail if the generated code is out of date.
If this is deemed useful, we can do a similar thing for the maps generated in markup5ever.