New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port windows implementation from winapi to windows-rs #302
Conversation
9acee56
to
e14cb59
Compare
Some deps are still using XAMPPRocky/remove_dir_all#43 that will eventually allow |
This is ready to be merged now. |
Any chance of getting this merged @jdm? It would also be nice to upgrade |
☔ The latest upstream changes (presumably #315) made this pull request unmergeable. Please resolve the merge conflicts. |
@Xaeroxe I just tried the tests here and two of them are hanging:
I've pushed a PR which further updates the |
This was due to a subtle bug in the tests. The closure appeared to be capturing a value but in actuality was capturing nothing due to the |
f1ceb03
to
17e7129
Compare
Thank you for doing this work! |
winapi
hasn't been updated since November of 2021, and the ecosystem seems to be making a general shift towards the officially supportedwindows
crate instead. This PR movesipc-channel
towindows
.