Regenerate mach bindings #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current 'mach_sys.rs' was generated before rust-bindgen started translating '#pragma pack(n)' directives into '#[repr(C, packed(n)]' attributes on the rust struct defintions. These missing attributes cause debug assertions to fail because of misaligned access to the fields when serializing and deserializing the structs for mach_msg calls (see servo#312). This PR regenerates the 'mach_sys.rs' file using the latest bindgen and mach headers from XCode MacOS SDK. It also introduces padding *before* the 'data size' field for messages with inline data so that they begin at 8-byte aligned addresses as required by rustc. Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
Latest rustc warns about drop() calls used on Copy types and drop() calls where a reference is passed instead of value. Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
This was referenced Aug 8, 2023
mstange
added a commit
to mstange/samply
that referenced
this pull request
Jan 25, 2024
This is a port of servo/ipc-channel#314 , originally written by Mukilan Thiyagarajan <me@mukilan.in> .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 'mach_sys.rs' was generated before rust-bindgen started translating '#pragma pack(n)' directives into
#[repr(C, packed(n)]attributes on the rust struct defintions. These missing attributes cause debug assertions to fail because of misaligned access to the fields when serializing and deserializing the structs for mach_msg calls (see #312 and this discussion).This PR regenerates the 'mach_sys.rs' file using the latest bindgen and mach headers from XCode MacOS SDK. It also introduces padding before the 'data size' field for messages with inline data so that they begin at 8-byte aligned addresses as required by rustc.
The second commit also fixes warnings emitted by latest rustc about drop() calls used on Copy types and drop() calls where a reference is passed instead of value.