Invert edge direction #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(part of #68) We currently have the edges going in the reverse direction as the audio, which is confusing. The reason we did this was so that we could use the DFSPostOrder iterator. This inverts their direction so that edges now go from source to sink, and uses a `Reversed` adaptor to fix it.
ferjm
approved these changes
Jul 4, 2018
| @@ -0,0 +1,2 @@ | |||
| [alias] | |||
| ex = "run -p examples --bin" | |||
There was a problem hiding this comment.
It would be nice to update the README section about running the examples to mention the existence of this alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(part of #68)
We currently have the edges going in the reverse direction as the audio,
which is confusing. The reason we did this was so that we could use the
DFSPostOrder iterator.
This inverts their direction so that edges now go from source to sink, and
uses a
Reversedadaptor to fix it.r? @ferjm