Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert edge direction #69

Merged
merged 2 commits into from Jul 4, 2018

Conversation

Projects
None yet
2 participants
@Manishearth
Copy link
Member

commented Jul 3, 2018

(part of #68)

We currently have the edges going in the reverse direction as the audio,
which is confusing. The reason we did this was so that we could use the
DFSPostOrder iterator.

This inverts their direction so that edges now go from source to sink, and
uses a Reversed adaptor to fix it.

r? @ferjm

Manishearth added some commits Jul 3, 2018

Invert edge direction
(part of #68)

We currently have the edges going in the reverse direction as the audio,
which is confusing. The reason we did this was so that we could use the
DFSPostOrder iterator.

This inverts their direction so that edges now go from source to sink,
and uses a `Reversed` adaptor to fix it.
@ferjm

ferjm approved these changes Jul 4, 2018

@@ -0,0 +1,2 @@
[alias]
ex = "run -p examples --bin"

This comment has been minimized.

Copy link
@ferjm

ferjm Jul 4, 2018

Member

It would be nice to update the README section about running the examples to mention the existence of this alias.

@ferjm ferjm merged commit 25b0fe0 into master Jul 4, 2018

@ferjm ferjm deleted the invert-edges branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.