Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UWP builds are broken #327

Closed
jdm opened this issue Dec 5, 2022 · 4 comments
Closed

UWP builds are broken #327

jdm opened this issue Dec 5, 2022 · 4 comments

Comments

@jdm
Copy link
Member

jdm commented Dec 5, 2022

https://github.com/servo/mozjs/actions/runs/3620237778/jobs/6102230493

 error: failed to add native library D:\a\mozjs\mozjs\target\aarch64-uwp-windows-msvc\debug\build\mozjs_sys-4605c0d63069ddd7\out\build/js/src/build\js_static.lib: Unsupported archive identifier

This error message happens when the object crate that rustc uses can't read an archive: https://github.com/gimli-rs/object/blob/ed03e05213421e74ba2ccd216efe0ca0e8e06d65/src/read/archive.rs#L64 . One way to investigate this would be to save the js_static.lib file from the github task and download it for further investigation.
@jdm jdm mentioned this issue Dec 5, 2022
Closed
@Redfire75369
Copy link
Contributor

Redfire75369 commented Dec 5, 2022 •
edited

You can use actions/upload-artifact to get your hands on the file. Something like this:

    - uses: actions/upload-artifact@v3
      with:
        name: debug-build
        path: target/debug/build/mozjs_sys-*/out/build/js/src/build/js_static.lib

@jdm jdm mentioned this issue Dec 11, 2022
Merged
@jdm
Copy link
Member Author

jdm commented Jan 6, 2023

I haven't made time to look into this yet. I'm going to disable the builds in the meantime.

@jdm jdm mentioned this issue Jan 6, 2023
Merged
bors-servo added a commit that referenced this issue Jan 6, 2023
@bors-servo
Auto merge of #333 - servo:jdm-patch-36, r=jdm
a95a8d3 
Disable UWP builds.

#327 is getting in the way of other changes.
@Psychpsyo
Copy link

Does this mean #328 is no longer blocked?

@Redfire75369 Redfire75369 mentioned this issue Jan 7, 2023
Closed
@sagudev sagudev mentioned this issue Jan 21, 2023
Merged
bors-servo added a commit that referenced this issue Jan 21, 2023
@bors-servo
Auto merge of #339 - sagudev:uwp2, r=jdm
0b37834 
Fix UWP builds

Only temporary fix of: #327
I think the main reason of fail was System LLVM and Rust LLVM become out of sync.
@jdm jdm mentioned this issue Jan 21, 2023
Open
@sagudev
Copy link
Member

sagudev commented Sep 11, 2023

UWP is removed.

@sagudev sagudev closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdm @sagudev @Redfire75369 @Psychpsyo