Added Methods for ObjectOpResult #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
requested changes
Aug 17, 2023
mrobinson
requested changes
Aug 17, 2023
mozjs/src/jsimpls.rs
Outdated
Comment on lines
396
to
397
| assert_ne!(self.code_, JS::ObjectOpResult_SpecialCodes::OkCode as usize); | ||
| self.code_ = code as usize; |
There was a problem hiding this comment.
This does something different than the C++ API which asserts that the argument isn't JS::ObjectOpResult_SpecialCodes::OkCode. Here you are asserting that the existing code isn't that.
From https://searchfox.org/mozilla-central/source/js/public/Class.h#123:
bool fail(uint32_t msg) {
MOZ_ASSERT(msg != OkCode);
code_ = msg;
return true;
}
mozjs/src/jsimpls.rs
Outdated
| #[allow(non_snake_case)] | ||
| pub fn failNoNamedSetter(&mut self) -> bool { | ||
| assert!(self.code_ != JS::ObjectOpResult_SpecialCodes::OkCode as usize); | ||
| assert_ne!(self.code_, ObjectOpResult_SpecialCodes::OkCode as usize); |
There was a problem hiding this comment.
There's the same issue here. This function can just be:
#[deprecated]
#[allow(non_snake_case)]
pub fn failNoNamedSetter(&mut self) -> bool {
self.fail_no_named_setter()
}
Mapped ObjectOpResult::failNoNamedSetter to ObjectOpResult::fail_no_named_setter
mrobinson
force-pushed
the
object-op-result-impl
branch
from
bb676ed
to
60d1805
Compare
|
Is this normal to be merged without https://github.com/servo/mozjs/actions/runs/5890501581 finished and with PR checks failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods are implemented according to https://searchfox.org/mozilla-central/source/js/public/Class.h#79-155 and https://searchfox.org/mozilla-central/source/js/src/jsapi.cpp#212-282.