Add FnvHashMap and FnvHashSet type aliases #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a much easier way to use FNV in the standard collections.
|
Note, the addition itself is trivial - -the bulk of the line changes are in related doc updates. |
|
FWIW, rustc's fnv also provides these type aliases, although I didn't copy from there. But that should be clear evidence that this is a useful thing to have. They also provide transparent type constructors, which probably is something I should steal for here. |
|
Looks good to me, thanks! Can you also bump the Cargo.toml version? Thanks again! |
|
Sure, there's the bump! |
|
@bors-servo: r+ Thanks! |
|
📌 Commit fd28754 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Sep 17, 2016
Add FnvHashMap and FnvHashSet type aliases This is a much easier way to use FNV in the standard collections. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-fnv/12) <!-- Reviewable:end -->
|
(Published, btw, sorry for the delay in doing it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much easier way to use FNV in the standard collections.
This change is