This repository has been archived by the owner on Nov 12, 2022. It is now read-only.
Add more APIs to work with AutoIdVector. #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is working towards servo/servo#13144 |
nox
suggested changes
Sep 15, 2016
| } | ||
| } | ||
|
|
||
| pub unsafe fn get(&self) -> *mut AutoIdVector { |
| self.0 | ||
| } | ||
|
|
||
| pub fn append(&mut self, id: jsid) -> bool { |
There was a problem hiding this comment.
This should be unsafe, given we can pass arbitrary jsid values.
Ms2ger
force-pushed
the
autoidvector
branch
2 times, most recently
from
7f9575a
to
94bb1bf
Compare
Ms2ger
force-pushed
the
autoidvector
branch
from
94bb1bf
to
df3e626
Compare
|
@bors-servo r+ |
|
📌 Commit df3e626 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 15, 2016
Add more APIs to work with AutoIdVector. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/305) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is