Implement FromJSValConvertible for HandleValue

[KiChjang]

This change is 

[KiChjang]

r? @jdm or @nox

[nox]

value may be from another context, AFAIK this would be incorrect.

[jdm]

We could add this:

unsafe {
    if value.is_object() {
        AssertSameCompartment(cx, value.to_object());
    }
}

[KiChjang]

Assertion added.

[jdm]

error[E0425]: cannot find value `cx` in this scope
   --> src\conversions.rs:197:39
    |
197 |                 AssertSameCompartment(cx, value.to_object());
    |                                       ^^ did you mean `_cx`?
error: aborting due to previous error

Please be sure this builds :)

[KiChjang]

bah humbug

[KiChjang]

'kay.

[jdm]

   Compiling mozjs_sys v0.0.0 (https://github.com/servo/mozjs#29132f67)
warning: unnecessary `unsafe` block
   --> src\conversions.rs:195:9
    |
195 |           unsafe {
    |  _________^ starting here...
196 | |             if value.is_object() {
197 | |                 AssertSameCompartment(cx, value.to_object());
198 | |             }
199 | |         }
    | |_________^ ...ending here: unnecessary `unsafe` block
    |
    = note: #[warn(unused_unsafe)] on by default
    Finished dev [unoptimized + debuginfo] target(s) in 622.32 secs
   Compiling js v0.1.4 (file:///C:/projects/rust-mozjs)
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
thread 'rustc' panicked at 'index out of bounds: the len is 8 but the index is 18446744073709551615', src\libcollections\vec.rs:1488
note: Run with `RUST_BACKTRACE=1` for a backtrace.
error: Could not compile `js`.
Build failed, waiting for other jobs to finish...
warning: unnecessary `unsafe` block
   --> src\conversions.rs:195:9
    |
195 |           unsafe {
    |  _________^ starting here...
196 | |             if value.is_object() {
197 | |                 AssertSameCompartment(cx, value.to_object());
198 | |             }
199 | |         }
    | |_________^ ...ending here: unnecessary `unsafe` block
    |
    = note: #[warn(unused_unsafe)] on by default
error: build failed

Unnerving. Fix the warning and let's see what happens?

[KiChjang]

omg, i don't know what's happening anymore, i just made a small change and rustc is so angry with me

[jdm]

Could you force push again? I'd like to see if this is an instance of rust-lang/rust#41415.

[jdm]

Nevermind, that's an actual assertion failure.

[jdm]

Filed rust-lang/rust#41484.

[jdm]

@bors-servo: r+

[bors-servo]

📌 Commit 04e9e3a has been approved by jdm

[bors-servo]

⌛ Testing commit 04e9e3a with merge 5ba3550...

[bors-servo]

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing 5ba3550 to master...