This repository has been archived by the owner on Nov 12, 2022. It is now read-only.
rust.rs: unsafe Handle::new() is now a private function. #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new() constructor is potentially unsafe because of the way it accepts pointers and isnt marked to indicate this. The usage occurrence of this function outside of this crate is also limited to one. To this end, marking it private would prevent potentially unsafe propagation.
sudarshan-reddy
changed the title
|
@bors-servo r+ |
|
📌 Commit 806aed5 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new() constructor is unsafe because of the way it accepts pointers
and isn't marked to indicate this. The usage occurrence of this function
outside of this crate is also limited to one. To thisend, marking it private
would prevent potentially unsafe propagation.