Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace bad grammar #217

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib.rs
Expand Up @@ -368,7 +368,7 @@ impl Url {

/// Return the origin of this URL (https://url.spec.whatwg.org/#origin)
///
/// Note: this return an opaque origin for `file:` URLs, which causes
/// Note: the return value is an opaque origin for `file:` URLs, which causes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equivalently, "this returns" would fix all of the problems here. Your new wording makes the "which causes..." part sound very strange since it isn't clear on what the "which" is referring to.

/// `url.origin() != url.origin()`.
///
/// # Examples
Expand Down