Use separate homu user for Homu-related states #615
Conversation
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @aneeshusa (or someone else) soon. |
ALikhachev
force-pushed
the
master
branch
3 times, most recently
from
bf2f61f
to
b895281
Compare
| user.present: | ||
| - fullname: Homu | ||
| - shell: /bin/bash | ||
| - home: /home/servo/homu |
There was a problem hiding this comment.
Homu should have its own home directory completely separate from servo, i.e. /home/homu. We'll also need to have some manual deployment steps for this to move the homu db to the right place by hand.
There was a problem hiding this comment.
We should also create a homu group as the primary group of the homu user.
| user.present: | ||
| - fullname: Homu | ||
| - shell: /bin/bash | ||
| - home: /home/servo/homu |
There was a problem hiding this comment.
We should also create a homu group as the primary group of the homu user.
|
|
||
|
|
||
| def run(): | ||
| for root, directories, filenames in os.walk('/home/servo/homu/'): |
There was a problem hiding this comment.
This will also check files like .profile for the homu user. I think it's OK if we only check permissions on Homu's cfg.toml file (and the database if it exists).
| - mode: 644 | ||
| - user: homu | ||
| - group: homu | ||
| - mode: 640 |
There was a problem hiding this comment.
Since this file is no longer world-readable, we'll need to run the tests with sudo from .travis/dispatch.sh. Please put this change in a separate commit first to make sure it doesn't break anything else.
|
☔ The latest upstream changes (presumably #476) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing as homu is no more. |
Fixes #422
This change is