Skip to content

Commit

Permalink
Auto merge of #12374 - jdm:jsup, r=Manishearth
Browse files Browse the repository at this point in the history
Improve performance of HTMLDivElement constructor

These changes address two sources of performance loss seen while profiling in #12354. #12358 and rust-lang/rust#34727 are still the biggest offenders, however.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't have performance tests and these are only optimizations

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12374)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Jul 10, 2016
2 parents 287969f + d0e3e61 commit 01ec849
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions components/script/dom/htmldivelement.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ impl HTMLDivElement {
pub fn new(localName: Atom,
prefix: Option<DOMString>,
document: &Document) -> Root<HTMLDivElement> {
let element = HTMLDivElement::new_inherited(localName, prefix, document);
Node::reflect_node(box element, document, HTMLDivElementBinding::Wrap)
Node::reflect_node(box HTMLDivElement::new_inherited(localName, prefix, document),
document,
HTMLDivElementBinding::Wrap)
}
}

Expand Down
2 changes: 1 addition & 1 deletion components/servo/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ports/cef/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 01ec849

Please sign in to comment.