Skip to content

Commit

Permalink
Remove unnecessary dependencies and features from top-level Cargo.tomls
Browse files Browse the repository at this point in the history
The features for each crate will be computed based on the union of features
specified in the dependency graph.  Specifying the same ones again just adds
more ways for them to get out of sync.
  • Loading branch information
mbrubeck committed May 11, 2016
1 parent cce5654 commit 0573d12
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 38 deletions.
2 changes: 1 addition & 1 deletion components/script/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,6 @@ smallvec = "0.1"
string_cache = {version = "0.2.12", features = ["heap_size", "unstable"]}
time = "0.1.12"
unicase = "1.0"
url = {version = "1.0.0", features = ["heap_size"]}
url = {version = "1.0.0", features = ["heap_size", "query_encoding"]}
uuid = { version = "0.2", features = ["v4"] }
websocket = "0.17"
2 changes: 0 additions & 2 deletions components/servo/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions components/servo/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,13 @@ devtools = {path = "../devtools"}
webdriver_server = {path = "../webdriver_server", optional = true}
devtools_traits = {path = "../devtools_traits"}
glutin_app = {path = "../../ports/glutin", optional = true}
android_glue = {version = "0.1.3", optional = true}
ipc-channel = {git = "https://github.com/servo/ipc-channel"}
layers = {git = "https://github.com/servo/rust-layers", features = ["plugins"]}
gleam = "0.2"
browserhtml = {git = "https://github.com/browserhtml/browserhtml", branch = "gh-pages"}
env_logger = "0.3"
euclid = {version = "0.6.4", features = ["plugins"]}
euclid = "0.6.4"
libc = "0.2"
url = {version = "1.0.0", features = ["heap_size", "serde", "query_encoding"]}
url = "1.0.0"

[target.'cfg(target_os = "android")'.dependencies]
log = "0.3"
Expand Down
1 change: 0 additions & 1 deletion components/servo/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ pub extern crate devtools_traits;
pub extern crate euclid;
pub extern crate gfx;
pub extern crate ipc_channel;
pub extern crate layers;
pub extern crate layout;
pub extern crate msg;
pub extern crate net;
Expand Down
6 changes: 0 additions & 6 deletions ports/cef/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 3 additions & 8 deletions ports/cef/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,22 @@ codegen-units = 4
# lto = false

[dependencies]
euclid = {version = "0.6.4", features = ["plugins"]}
euclid = "0.6.4"
gleam = "0.2.8"
libc = "0.2"
url = {version = "1.0.0", features = ["heap_size"]}
url = "1.0.0"
servo = {path = "../../components/servo"}
glutin_app = {path = "../glutin"}
plugins = {path = "../../components/plugins"}
compositing = {path = "../../components/compositing"}
gfx = {path = "../../components/gfx"}
log = {version = "0.3.5", features = ["release_max_level_info"]}
script = {path = "../../components/script"}
script_traits = {path = "../../components/script_traits"}
net_traits = {path = "../../components/net_traits"}
msg = {path = "../../components/msg"}
util = {path = "../../components/util", features = ["non-geckolib"]}
style = {path = "../../components/style"}
style_traits = {path = "../../components/style_traits"}
devtools = {path = "../../components/devtools"}
azure = {git = "https://github.com/servo/rust-azure", features = ["plugins"]}
js = {git = "https://github.com/servo/rust-mozjs"}
layers = {git = "https://github.com/servo/rust-layers", features = ["plugins"]}
layers = {git = "https://github.com/servo/rust-layers"}

[target.'cfg(target_os="macos")'.dependencies]
objc = "0.2"
Expand Down
5 changes: 0 additions & 5 deletions ports/cef/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,16 @@ extern crate log;
extern crate servo;
extern crate compositing;

extern crate azure;
extern crate euclid;
extern crate gfx;
extern crate gleam;
extern crate glutin_app;
extern crate js;
extern crate layers;
extern crate rustc_unicode;
extern crate script;
extern crate script_traits;

extern crate net_traits;
extern crate msg;
extern crate util;
extern crate style;
extern crate style_traits;

extern crate libc;
Expand Down
1 change: 0 additions & 1 deletion ports/geckolib/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions ports/geckolib/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ path = "lib.rs"
crate-type = ["staticlib"]

[dependencies]
app_units = {version = "0.2.3", features = ["plugins"]}
cssparser = {version = "0.5.4", features = ["heap_size", "serde-serialization"]}
euclid = {version = "0.6.4", features = ["plugins"]}
app_units = "0.2.3"
cssparser = "0.5.4"
euclid = "0.6.4"
heapsize = "0.3.0"
heapsize_plugin = "0.1.2"
lazy_static = "0.2"
libc = "0.2"
num_cpus = "0.2.2"
selectors = {version = "0.5", features = ["heap_size", "unstable"]}
selectors = "0.5"
smallvec = "0.1"
string_cache = {version = "0.2.12", features = ["heap_size", "unstable"]}
url = {version = "1.0.0", features = ["heap_size", "query_encoding", "serde"]}
string_cache = "0.2.12"
url = "1.0.0"
log = {version = "0.3.5", features = ["release_max_level_info"]}
plugins = {path = "../../components/plugins"}
util = {path = "../../components/util"}
Expand Down
1 change: 0 additions & 1 deletion ports/gonk/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions python/servo/build_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,6 @@ def build(self, target=None, release=False, dev=False, jobs=None,
if debug_mozjs or self.config["build"]["debug-mozjs"]:
features += ["script/debugmozjs"]

if android:
features += ["android_glue"]

if features:
opts += ["--features", "%s" % ' '.join(features)]

Expand Down

0 comments on commit 0573d12

Please sign in to comment.