Skip to content

Commit

Permalink
Auto merge of #12156 - jimberlage:12153/mime-type-s3, r=aneeshusa
Browse files Browse the repository at this point in the history
Adds explicit mime type to upload_nightly.sh

<!-- Please describe your changes on the following line: -->
This changes the script to pass the `--mime-type` option to `s3cmd`, as
described [here](http://s3tools.org/usage).  The MIME type used is
`application/octet-stream`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #12153 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because this is a minimal change to the upload_nightly.sh script.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12156)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Jul 2, 2016
2 parents 40909ed + 137bf9f commit 1b8a264
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion etc/ci/upload_nightly.sh
Expand Up @@ -16,7 +16,8 @@ upload() {
package_filename="$(basename "${2}")"
local -r nightly_upload_dir="s3://servo-builds/nightly/${1}"
local -r package_upload_path="${nightly_upload_dir}/${package_filename}"
s3cmd put "${2}" "${package_upload_path}"
s3cmd --mime-type="application/octet-stream" \
put "${2}" "${package_upload_path}"
s3cmd cp "${package_upload_path}" "${nightly_upload_dir}/servo-latest.${3}"
}

Expand Down

0 comments on commit 1b8a264

Please sign in to comment.