Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Add onmessageerror to WindowEventHandler
  • Loading branch information
KiChjang committed Dec 12, 2018
1 parent 95bfaa0 commit 3ee5a63
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 48 deletions.
2 changes: 2 additions & 0 deletions components/script/dom/macros.rs
Expand Up @@ -495,6 +495,7 @@ macro_rules! window_event_handlers(
event_handler!(languagechange, GetOnlanguagechange,
SetOnlanguagechange);
event_handler!(message, GetOnmessage, SetOnmessage);
event_handler!(messageerror, GetOnmessageerror, SetOnmessageerror);
event_handler!(offline, GetOnoffline, SetOnoffline);
event_handler!(online, GetOnonline, SetOnonline);
event_handler!(pagehide, GetOnpagehide, SetOnpagehide);
Expand Down Expand Up @@ -527,6 +528,7 @@ macro_rules! window_event_handlers(
window_owned_event_handler!(languagechange, GetOnlanguagechange,
SetOnlanguagechange);
window_owned_event_handler!(message, GetOnmessage, SetOnmessage);
window_owned_event_handler!(messageerror, GetOnmessageerror, SetOnmessageerror);
window_owned_event_handler!(offline, GetOnoffline, SetOnoffline);
window_owned_event_handler!(online, GetOnonline, SetOnonline);
window_owned_event_handler!(pagehide, GetOnpagehide, SetOnpagehide);
Expand Down
1 change: 1 addition & 0 deletions components/script/dom/webidls/EventHandler.webidl
Expand Up @@ -103,6 +103,7 @@ interface WindowEventHandlers {
attribute EventHandler onhashchange;
attribute EventHandler onlanguagechange;
attribute EventHandler onmessage;
attribute EventHandler onmessageerror;
attribute EventHandler onoffline;
attribute EventHandler ononline;
attribute EventHandler onpagehide;
Expand Down
18 changes: 0 additions & 18 deletions tests/wpt/metadata/html/dom/interfaces.https.html.ini
Expand Up @@ -5995,9 +5995,6 @@
[Window interface: attribute onsecuritypolicyviolation]
expected: FAIL

[Window interface: attribute onmessageerror]
expected: FAIL

[Window interface: operation createImageBitmap(ImageBitmapSource, ImageBitmapOptions)]
expected: FAIL

Expand Down Expand Up @@ -6067,9 +6064,6 @@
[Window interface: window must inherit property "onsecuritypolicyviolation" with the proper type]
expected: FAIL

[Window interface: window must inherit property "onmessageerror" with the proper type]
expected: FAIL

[Window interface: window must inherit property "createImageBitmap(ImageBitmapSource, ImageBitmapOptions)" with the proper type]
expected: FAIL

Expand Down Expand Up @@ -6288,9 +6282,6 @@
[HTMLBodyElement interface: attribute aLink]
expected: FAIL

[HTMLBodyElement interface: attribute onmessageerror]
expected: FAIL

[HTMLBodyElement interface: document.createElement("body") must inherit property "link" with the proper type]
expected: FAIL

Expand All @@ -6300,9 +6291,6 @@
[HTMLBodyElement interface: document.createElement("body") must inherit property "aLink" with the proper type]
expected: FAIL

[HTMLBodyElement interface: document.createElement("body") must inherit property "onmessageerror" with the proper type]
expected: FAIL

[HTMLHeadingElement interface: attribute align]
expected: FAIL

Expand Down Expand Up @@ -9555,18 +9543,12 @@
[HTMLFrameSetElement interface: attribute rows]
expected: FAIL

[HTMLFrameSetElement interface: attribute onmessageerror]
expected: FAIL

[HTMLFrameSetElement interface: document.createElement("frameset") must inherit property "cols" with the proper type]
expected: FAIL

[HTMLFrameSetElement interface: document.createElement("frameset") must inherit property "rows" with the proper type]
expected: FAIL

[HTMLFrameSetElement interface: document.createElement("frameset") must inherit property "onmessageerror" with the proper type]
expected: FAIL

[HTMLFrameElement interface: attribute name]
expected: FAIL

Expand Down
Expand Up @@ -9,9 +9,6 @@
[shadowed error (document.body)]
expected: FAIL

[shadowed messageerror (document.body)]
expected: FAIL

[not shadowed auxclick (document.body)]
expected: FAIL

Expand All @@ -30,15 +27,9 @@
[not shadowed paste (document.body)]
expected: FAIL

[shadowed messageerror removal (document.body)]
expected: FAIL

[shadowed error (document.createElement("body"))]
expected: FAIL

[shadowed messageerror (document.createElement("body"))]
expected: FAIL

[not shadowed auxclick (document.createElement("body"))]
expected: FAIL

Expand All @@ -57,6 +48,3 @@
[not shadowed paste (document.createElement("body"))]
expected: FAIL

[shadowed messageerror removal (document.createElement("body"))]
expected: FAIL

Expand Up @@ -8,9 +8,6 @@
[shadowed error]
expected: FAIL

[shadowed messageerror]
expected: FAIL

[not shadowed auxclick]
expected: FAIL

Expand All @@ -20,6 +17,3 @@
[not shadowed securitypolicyviolation]
expected: FAIL

[shadowed messageerror removal]
expected: FAIL

Expand Up @@ -5,12 +5,6 @@
[Ignore setting of error window event handlers on windowless body]
expected: FAIL

[Return null when getting the messageerror event handler of a windowless body]
expected: FAIL

[Ignore setting of messageerror window event handlers on windowless body]
expected: FAIL

[auxclick is unaffected on a windowless body]
expected: FAIL

Expand All @@ -23,12 +17,6 @@
[Ignore setting of error window event handlers on windowless frameset]
expected: FAIL

[Return null when getting the messageerror event handler of a windowless frameset]
expected: FAIL

[Ignore setting of messageerror window event handlers on windowless frameset]
expected: FAIL

[auxclick is unaffected on a windowless frameset]
expected: FAIL

Expand Down

0 comments on commit 3ee5a63

Please sign in to comment.