Split parse_url to allow for external error handling

servo · May 6, 2014 · 470250e · 470250e · bors-servo · May 6, 2014
1 parent 310d2a1
commit 470250e
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/components/util/url.rs b/src/components/util/url.rs
@@ -17,7 +17,7 @@ Create a URL object from a string. Does various helpful browsery things like
 
 */
 // TODO: about:failure->
-pub fn parse_url(str_url: &str, base_url: Option<std_url::Url>) -> std_url::Url {
+pub fn try_parse_url(str_url: &str, base_url: Option<std_url::Url>) -> Result<std_url::Url, ~str> {
     let str_url = str_url.trim_chars(& &[' ', '\t', '\n', '\r', '\x0C']).to_owned();
     let schm = std_url::get_scheme(str_url);
     let str_url = match schm {
@@ -83,10 +83,15 @@ pub fn parse_url(str_url: &str, base_url: Option<std_url::Url>) -> std_url::Url
         }
     };
 
+    std_url::from_str(str_url)
+}
+
+pub fn parse_url(str_url: &str, base_url: Option<std_url::Url>) -> std_url::Url {
     // FIXME: Need to handle errors
-    std_url::from_str(str_url).ok().expect("URL parsing failed")
+    try_parse_url(str_url, base_url).ok().expect("URL parsing failed")
 }
 
+
 #[cfg(test)]
 mod parse_url_tests {
     use super::parse_url;