Address review comments

servo · Dec 9, 2014 · 8686b67 · 8686b67
1 parent b1f79e2
commit 8686b67
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/components/script/dom/htmltitleelement.rs b/components/script/dom/htmltitleelement.rs
@@ -77,9 +77,9 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLTitleElement> {
         Some(htmlelement as &VirtualMethods)
     }
 
-    fn bind_to_tree(&self, _: bool) {
+    fn bind_to_tree(&self, is_in_doc: bool) {
         let node: JSRef<Node> = NodeCast::from_ref(*self);
-        if node.is_in_doc() {
+        if is_in_doc {
             let document = node.owner_doc().root();
             document.send_title_to_compositor()
         }

diff --git a/ports/android/glut_app/window.rs b/ports/android/glut_app/window.rs
@@ -177,14 +177,18 @@ impl WindowMethods for Window {
     fn set_ready_state(&self, ready_state: ReadyState) {
         self.ready_state.set(ready_state);
         // FIXME: set_window_title causes crash with Android version of freeGLUT. Temporarily
-        // blocked. self.update_window_title()
+        // blocked.
+        //
+        // self.update_window_title()
     }
 
     /// Sets the paint state.
     fn set_paint_state(&self, paint_state: PaintState) {
         self.paint_state.set(paint_state);
         // FIXME: set_window_title causes crash with Android version of freeGLUT. Temporarily
-        // blocked. self.update_window_title()
+        // blocked.
+        //
+        // self.update_window_title()
     }
 
     fn hidpi_factor(&self) -> ScaleFactor<ScreenPx, DevicePixel, f32> {