Skip to content

Commit

Permalink
clarify comments and new fields
Browse files Browse the repository at this point in the history
  • Loading branch information
delan committed Sep 6, 2023
1 parent db246af commit c1a6558
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion components/constellation/constellation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2844,7 +2844,8 @@ where
top_level_browsing_context_id,
browsing_context_id,
new_pipeline_id,
// pipeline already closed, so Yes avoids harmless but useless close
// Pipeline already closed by close_browsing_context_children, so we can pass Yes here
// to avoid closing again in handle_activate_document_msg (though it would be harmless)
replace: Some(NeedsToReload::Yes(old_pipeline_id, old_load_data)),
new_browsing_context_info: None,
window_size,
Expand Down
2 changes: 2 additions & 0 deletions components/net_traits/request.rs
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ pub struct RequestBuilder {
pub initiator: Initiator,
pub https_state: HttpsState,
pub response_tainting: ResponseTainting,
/// Servo internal: if crash details are present, trigger a crash error page with these details
pub crash: Option<String>,
}

Expand Down Expand Up @@ -496,6 +497,7 @@ pub struct Request {
#[ignore_malloc_size_of = "Defined in rust-content-security-policy"]
pub csp_list: Option<CspList>,
pub https_state: HttpsState,
/// Servo internal: if crash details are present, trigger a crash error page with these details
pub crash: Option<String>,
}

Expand Down
2 changes: 1 addition & 1 deletion components/script_traits/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ pub struct LoadData {
/// The inherited context is Secure, None if not inherited
pub inherited_secure_context: Option<bool>,

/// Crash details, if we are reloading to a crash error page.
/// Servo internal: if crash details are present, trigger a crash error page with these details
pub crash: Option<String>,
}

Expand Down

0 comments on commit c1a6558

Please sign in to comment.