Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Obey white-space when intrinsically sizing an IFC
The old logic was assuming that all whitespace was a break opportunity, and that no newlines would be preserved. Note that text shaping considers the advance of a newline to be the same as a space. This was problematic because if we have a segment with a preserved space and newline, only the advance of the space should contrinute to the size of the block container. Therefore, I'm changing the breaker logic in other to have newline characters in their own segment. Then glyph_run_is_whitespace_ending_with_preserved_newline can just be renamed to glyph_run_is_preserved_newline.
- Loading branch information
1 parent
0e78c81
commit e28bfe5
Showing
23 changed files
with
70 additions
and
69 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/CSS2/generated-content/content-175.xht.ini
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/CSS2/tables/table-anonymous-objects-009.xht.ini
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/CSS2/tables/table-anonymous-objects-010.xht.ini
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/CSS2/tables/table-anonymous-objects-011.xht.ini
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/CSS2/tables/table-anonymous-objects-012.xht.ini
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/CSS2/tables/table-anonymous-objects-197.xht.ini
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/CSS2/tables/table-anonymous-objects-198.xht.ini
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
2 changes: 2 additions & 0 deletions
2
tests/wpt/meta/css/css-text/tab-size/tab-size-integer-001.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[tab-size-integer-001.html] | ||
expected: FAIL |
2 changes: 2 additions & 0 deletions
2
tests/wpt/meta/css/css-text/tab-size/tab-size-integer-002.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[tab-size-integer-002.html] | ||
expected: FAIL |
2 changes: 2 additions & 0 deletions
2
tests/wpt/meta/css/css-text/tab-size/tab-size-integer-003.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[tab-size-integer-003.html] | ||
expected: FAIL |
2 changes: 2 additions & 0 deletions
2
tests/wpt/meta/css/css-text/tab-size/tab-size-length-001.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[tab-size-length-001.html] | ||
expected: FAIL |
2 changes: 2 additions & 0 deletions
2
tests/wpt/meta/css/css-text/tab-size/tab-size-length-002.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[tab-size-length-002.html] | ||
expected: FAIL |
2 changes: 2 additions & 0 deletions
2
tests/wpt/meta/css/css-text/tab-size/tab-size-percent-001.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[tab-size-percent-001.html] | ||
expected: FAIL |
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/css-text/white-space/white-space-intrinsic-size-015.html.ini
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/css-text/white-space/white-space-intrinsic-size-016.html.ini
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
tests/wpt/meta/css/css-text/white-space/white-space-intrinsic-size-018.html.ini
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[white-space-pre-wrap.htm] | ||
expected: FAIL |
2 changes: 0 additions & 2 deletions
2
tests/wpt/mozilla/meta/css/white_space_intrinsic_sizes_a.html.ini
This file was deleted.
Oops, something went wrong.