Skip to content

Commit

Permalink
explicitly specify bitness for x86 cross-compilation situations
Browse files Browse the repository at this point in the history
Despite compiling for architecture X, the user may have specified a
clang that defaults to architecture Y.  We need to ensure that we invoke
clang with the correct architecture selection.  We do not use --target
to do this, however, because that runs into problems with LLVM's default
search paths.  For the x86 case, we can simply use -m$BITNESS to select
the correct architecture.
  • Loading branch information
froydnj committed May 12, 2017
1 parent 121662a commit e966d97
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions components/style/build_gecko.rs
Expand Up @@ -153,6 +153,15 @@ mod bindings {
}
if cfg!(target_os = "linux") {
builder = builder.clang_arg("-DOS_LINUX=1");
// We may be cross-compiling with a clang that defaults to
// a different architecture, so we should explicitly specify
// the bitness being used here. Specifying --target instead
// leads to difficulties with LLVM search paths.
if cfg!(target_arch = "x86") {
builder = builder.clang_arg("-m32")
} else if cfg!(target_arch = "x86_64") {
builder = builder.clang_arg("-m64")
}
} else if cfg!(target_os = "solaris") {
builder = builder.clang_arg("-DOS_SOLARIS=1");
} else if cfg!(target_os = "dragonfly") {
Expand Down

0 comments on commit e966d97

Please sign in to comment.