Skip to content

Commit

Permalink
Auto merge of #10247 - eddyb:document-base-url, r=<try>
Browse files Browse the repository at this point in the history
Use <base> in resolving url attributes (like "href").

Second take of #6303, now that the `base_url` infrastructure is in place.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10247)
<!-- Reviewable:end -->
  • Loading branch information
bors-servo committed Mar 28, 2016
2 parents cf4fa0a + cffc634 commit f59e89e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/script/dom/element.rs
Expand Up @@ -1078,7 +1078,7 @@ impl Element {
}
let url = self.get_string_attribute(local_name);
let doc = document_from_node(self);
let base = doc.url();
let base = doc.base_url();
// https://html.spec.whatwg.org/multipage/#reflect
// XXXManishearth this doesn't handle `javascript:` urls properly
match base.join(&url) {
Expand Down

0 comments on commit f59e89e

Please sign in to comment.