Replies: 9 comments
-
Off the top of my head, we can rename it as |
Beta Was this translation helpful? Give feedback.
-
+1 for the FooChannel one |
Beta Was this translation helpful? Give feedback.
-
BTW we might use FooChan if the longer one is too verbose. Also the irc paste for reference here:
|
Beta Was this translation helpful? Give feedback.
-
-100 on "channel" or "chan". The thing you send on is a "sender"; a "channel" is something with two sides. |
Beta Was this translation helpful? Give feedback.
-
How about |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
Do we still care about this? |
Beta Was this translation helpful? Give feedback.
-
Yes, but it's low priority. While we're at it, the naming of the *Msg types is a bit erratic. |
Beta Was this translation helpful? Give feedback.
-
The naming is starting to get on my nerves. >< |
Beta Was this translation helpful? Give feedback.
-
This is a follow-up of discussion started from #11189.
The naming issues include:
Thread
is notIpcSender
: we type-alias a lot likeFooThread = IpcSender<FooMsg>
. The "thread" here might not be indicating what we wantnet_traits::IpcSend
is coupled withIpc
which might not be a good name (as suggested by @nox)net_traits::CoreResourceMsg
and others renamed from originalControlMsg
andResourceThread
. But theCoreResourceMsg
manages a lot of duties and used by a lot of other code, which might add difficulty to name it cleanly.Beta Was this translation helpful? Give feedback.
All reactions