Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed services support #11580

Merged
merged 1 commit into from Jun 5, 2016
Merged

Allowed services support #11580

merged 1 commit into from Jun 5, 2016

Conversation

zakorgy
Copy link
Contributor

@zakorgy zakorgy commented Jun 3, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because there are no webbluetooth test api implementation yet.

This change is Reviewable

@highfive
Copy link

highfive commented Jun 3, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net_traits/bluetooth_scanfilter.rs, components/net_traits/bluetooth_scanfilter.rs, components/net/bluetooth_thread.rs

@highfive
Copy link

highfive commented Jun 3, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 3, 2016
@zakorgy
Copy link
Contributor Author

zakorgy commented Jun 3, 2016

r? @jdm

@highfive highfive assigned jdm and unassigned glennw Jun 3, 2016
@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 3, 2016
@jdm
Copy link
Member

jdm commented Jun 3, 2016

-S-awaiting-review +S-needs-code-changes

Previously, zakorgy (zakorgy) wrote…

r? @jdm

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

components/net_traits/bluetooth_scanfilter.rs, line 23 [r1] (raw file):

    fn get_services_set(&self) -> HashSet<String> {
        let mut set = HashSet::new();
        self.0.iter().map(|m| set.insert(m.clone())).collect::<Vec<_>>();

This makes more sense as

for m in self.0.iter() {
    set.insert(m.clone());
}

Comments from Reviewable

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Jun 4, 2016
@highfive
Copy link

highfive commented Jun 4, 2016

New code was committed to pull request.

@zakorgy
Copy link
Contributor Author

zakorgy commented Jun 4, 2016

r? @jdm

@jdm jdm added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 4, 2016
@jdm
Copy link
Member

jdm commented Jun 4, 2016

Please squash, and then this can merge.

@highfive
Copy link

highfive commented Jun 4, 2016

New code was committed to pull request.

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 4, 2016
@zakorgy
Copy link
Contributor Author

zakorgy commented Jun 4, 2016

@jdm ?

@KiChjang
Copy link
Contributor

KiChjang commented Jun 4, 2016

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

📌 Commit 174516a has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-squash Some (or all) of the commits in the PR should be combined. labels Jun 4, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 174516a with merge 8af6dc6...

bors-servo pushed a commit that referenced this pull request Jun 4, 2016
Auto merge of #11580 - szeged:allowedservices, r=jdm
8af6dc6 
Allowed services support

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because there are no webbluetooth test api implementation yet.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11580)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jun 4, 2016
@highfive
Copy link

highfive commented Jun 4, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform3d-translatez-001.htm
  └   → /css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-ref.htm b14318ccfd8a59b7b249d41521e178d617678823
Testing 902d90a8d198625335e738587fdfe81dcc90392d == b14318ccfd8a59b7b249d41521e178d617678823
/css-transforms-1_dev/html/transform3d-translatez-001.htm 902d90a8d198625335e738587fdfe81dcc90392d
/css-transforms-1_dev/html/reference/transform3d-translatez-notref.htm 902d90a8d198625335e738587fdfe81dcc90392d
Testing 902d90a8d198625335e738587fdfe81dcc90392d != 902d90a8d198625335e738587fdfe81dcc90392d

@dati91
Copy link
Contributor

dati91 commented Jun 5, 2016

This fail seems unrelated to this patch

@KiChjang
Copy link
Contributor

KiChjang commented Jun 5, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 174516a with merge 939da24...

bors-servo pushed a commit that referenced this pull request Jun 5, 2016
Auto merge of #11580 - szeged:allowedservices, r=jdm
939da24 
Allowed services support

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because there are no webbluetooth test api implementation yet.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11580)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jun 5, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 174516a into servo:master Jun 5, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 5, 2016
@dati91 dati91 deleted the allowedservices branch July 22, 2016 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zakorgy @highfive @jdm @KiChjang @bors-servo @dati91 @glennw