Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some stuff from util to style #12256

Merged
merged 2 commits into from Jul 5, 2016
Merged

Move some stuff from util to style #12256

merged 2 commits into from Jul 5, 2016

Conversation

nox
Copy link
Contributor

@nox nox commented Jul 5, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented Jul 5, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/traversal.rs, components/style/lib.rs, components/style/tid.rs, components/style/attr.rs, components/style/str.rs
  • @KiChjang: components/script/dom/htmlcollection.rs, components/script/dom/htmlmetaelement.rs, components/script/dom/window.rs, components/script/dom/document.rs, components/script/dom/htmloptionelement.rs, components/script/dom/htmlfontelement.rs, components/script/dom/htmllinkelement.rs, components/script/dom/htmlinputelement.rs, components/script/dom/htmlscriptelement.rs, components/script/dom/domtokenlist.rs, components/script/dom/htmlformelement.rs, components/script/layout_wrapper.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 5, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 5, 2016

r+ once the unit tests pass

@nox
Copy link
Contributor Author

nox commented Jul 5, 2016

@bors-servo r=Ms2ger

@bors-servo
Copy link
Contributor

📌 Commit 8ecb596 has been approved by Ms2ger

@highfive highfive assigned Ms2ger and unassigned larsbergstrom Jul 5, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 5, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 8ecb596 with merge bb916bb...

bors-servo pushed a commit that referenced this pull request Jul 5, 2016
Auto merge of #12256 - nox:die-util-die, r=Ms2ger
bb916bb 
Move some stuff from util to style

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12256)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 5, 2016
@highfive
Copy link

highfive commented Jul 5, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728

@nox
Copy link
Contributor Author

nox commented Jul 5, 2016

@bors-servo retry #11574

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 8ecb596 into servo:master Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nox @highfive @Ms2ger @bors-servo @larsbergstrom