Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Runnable trait name method for ImageResponseHandlerRunnable #12345

Closed
cbrewster opened this issue Jul 8, 2016 · 2 comments · Fixed by #12375
Closed

Implement Runnable trait name method for ImageResponseHandlerRunnable #12345

cbrewster opened this issue Jul 8, 2016 · 2 comments · Fixed by #12375
Labels
A-content/script Related to the script thread E-less-complex Straightforward. Recommended for a new contributor.

Comments

@cbrewster
Copy link
Contributor

Implement the Runnable trait name method for ImageResponseHandlerRunnable. The method should return the string: ImageResponseHandlerRunnable.

See StorageEventRunnable in components/script/dom/storage.rs as an example.

Code: components/script/dom/htmlimageelement.rs

No test changes are needed, it just needs to compile successfully.
@cbrewster cbrewster added E-less-complex Straightforward. Recommended for a new contributor. A-content/script Related to the script thread labels Jul 8, 2016
@highfive
Copy link

highfive commented Jul 8, 2016

Please make a comment here if you intend to work on this issue. Thank you!

@gpoesia
Copy link
Contributor

gpoesia commented Jul 10, 2016

I'll take this.

@gpoesia gpoesia mentioned this issue Jul 10, 2016
Merged
4 tasks
bors-servo pushed a commit that referenced this issue Jul 10, 2016
Auto merge of #12375 - gpoesia:master, r=KiChjang
c6827a9 
Implement Runnable::name() for ImageResponseHandlerRunnable

<!-- Please describe your changes on the following line: -->

Implement the name() method from the Runnable trait for ImageResponseHandlerRunnable.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12345 (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests because it's stated in the issue (the change is trivial).

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12375)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script Related to the script thread E-less-complex Straightforward. Recommended for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Runnable::name() for ImageResponseHandlerRunnable gpoesia/servo
3 participants
@gpoesia @highfive @cbrewster