Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement HTMLDialogElement#close #12352

Closed
KiChjang opened this issue Jul 8, 2016 · 7 comments · Fixed by #12847
Closed

Implement HTMLDialogElement#close #12352

KiChjang opened this issue Jul 8, 2016 · 7 comments · Fixed by #12847
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-enhancement No impact; the issue is a missing or proposed feature.

Comments

@KiChjang
Copy link
Contributor

KiChjang commented Jul 8, 2016

Spec: https://html.spec.whatwg.org/multipage/forms.html#htmldialogelement
Code: components/script/dom/htmldialogelement.rs, components/script/dom/webidls/HTMLDialogElement.webidl
Test: tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close.html
@KiChjang KiChjang added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-enhancement No impact; the issue is a missing or proposed feature. labels Jul 8, 2016
@highfive
Copy link

highfive commented Jul 8, 2016

Please make a comment here if you intend to work on this issue. Thank you!

@KiChjang
Copy link
Contributor Author

KiChjang commented Jul 8, 2016 •
edited

This is assigned to @tallowen, claimed in IRC.

@KiChjang KiChjang added the C-assigned There is someone working on resolving the issue label Jul 8, 2016
@KiChjang
Copy link
Contributor Author

@tallowen Are you still working on this issue?

@tallowen
Copy link
Contributor

Yes - I went unexpectedly off the grid for a week. Sorry about the delay!

On Thu, Jul 21, 2016 at 9:41 AM, Keith Yeung notifications@github.com
wrote:

@tallowen https://github.com/tallowen Are you still working on this
issue?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12352 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAiCeedtq85NvhARsSdWQo0WaTTYygF_ks5qXyKigaJpZM4JIE9q
.

Owen Coutts

Email: owen@owencoutts.com
Phone: 206.651.4004

@clstl
Copy link

clstl commented Aug 1, 2016

@tallowen mind if I open a PR or are you willing to continue working?

@KiChjang
Copy link
Contributor Author

Unassigning @tallowen since we haven't heard back in 3 weeks.

@clstl Have you finished working on this? If so, it's good for a PR now.

@clstl
Copy link

clstl commented Aug 13, 2016

@KiChjang on it!

@clstl clstl mentioned this issue Aug 13, 2016
Merged
4 tasks
bors-servo pushed a commit that referenced this issue Aug 18, 2016
Auto merge of #12847 - clstl:HTMLDialogElement#close, r=<try>
4ea6b3c 
Implements HTMLDialogElement#close

<!-- Please describe your changes on the following line: -->
Implements HTMLDialogElement#close according to [link](https://html.spec.whatwg.org/multipage/#the-dialog-element:dom-dialog-close)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12352
- [X] There are tests for these change

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12847)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Aug 24, 2016
Auto merge of #12847 - clstl:HTMLDialogElement#close, r=nox
ff1f9d4 
Implements HTMLDialogElement#close

<!-- Please describe your changes on the following line: -->
Implements HTMLDialogElement#close according to [link](https://html.spec.whatwg.org/multipage/#the-dialog-element:dom-dialog-close)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12352
- [X] There are tests for these change

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12847)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Aug 25, 2016
Auto merge of #12847 - clstl:HTMLDialogElement#close, r=nox
f4bd1b2 
Implements HTMLDialogElement#close

<!-- Please describe your changes on the following line: -->
Implements HTMLDialogElement#close according to [link](https://html.spec.whatwg.org/multipage/#the-dialog-element:dom-dialog-close)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12352
- [X] There are tests for these change

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12847)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-enhancement No impact; the issue is a missing or proposed feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements HTMLDialogElement#close clstl/servo
4 participants
@tallowen @clstl @KiChjang @highfive