Use explicit height of inline-block fragments #12642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
LGTM. Squash if you like, then r=me. |
|
|
@bors-servo r=asajeffrey |
|
📌 Commit 129d1d6 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jul 29, 2016
Use explicit height of inline-block fragments When an explicit height is used for inline-block fragments, the line spacing algorithm should use that for the height above the baseline, instead of the intrinsic one. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12492 (github issue number if applicable). - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12642) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
highfive
removed
the
S-awaiting-merge
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
Oct 12, 2016
fragments if `overflow` is not `visible` per CSS 2.1 § 10.8.1. Additionally, this patch reverts the change introduced in servo#12642 in favor of the spec-compliant behavior described above. This patch also removes the `inline_block_overflow.html` reftest introduced in servo#3725, as the behavior it expected contradicted CSS 2.1 (and in fact the test fails in Gecko). The changes that this patch makes to `input_selection_a.html` and `input_selection_incremental_a.html` are necessary workarounds to make the tests pass in light of the fact that Servo's UA stylesheet applies `overflow: hidden` to `<input>` elements. I believe that the changes are not necessary in other rendering engines because they hard-code `overflow: hidden`-like behavior for `<input>` elements, while Servo uses the actual CSS `overflow: hidden` behavior. As far as I can tell, Servo's behavior is arguably more spec-compliant, but it remains to be seen how Web compatible it is. Improves the Google results pages. Closes servo#13707.
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
Oct 12, 2016
fragments if `overflow` is not `visible` per CSS 2.1 § 10.8.1. Additionally, this patch reverts the change introduced in servo#12642 in favor of the spec-compliant behavior described above. This patch also removes the `inline_block_overflow.html` reftest introduced in servo#3725, as the behavior it expected contradicted CSS 2.1 (and in fact the test fails in Gecko). The changes that this patch makes to `input_selection_a.html` and `input_selection_incremental_a.html` are necessary workarounds to make the tests pass in light of the fact that Servo's UA stylesheet applies `overflow: hidden` to `<input>` elements. I believe that the changes are not necessary in other rendering engines because they hard-code `overflow: hidden`-like behavior for `<input>` elements, while Servo uses the actual CSS `overflow: hidden` behavior. As far as I can tell, Servo's behavior is arguably more spec-compliant, but it remains to be seen how Web compatible it is. Improves the Google results pages. Closes servo#13707.
bors-servo
pushed a commit
that referenced
this pull request
Oct 13, 2016
… r=notriddle layout: Use the margin box for vertical positioning of `inline-block` fragments if `overflow` is not `visible` per CSS 2.1 § 10.8.1. Additionally, this patch reverts the change introduced in #12642 in favor of the spec-compliant behavior described above. This patch also removes the `inline_block_overflow.html` reftest introduced in #3725, as the behavior it expected contradicted CSS 2.1 (and in fact the test fails in Gecko). The changes that this patch makes to `input_selection_a.html` and `input_selection_incremental_a.html` are necessary workarounds to make the tests pass in light of the fact that Servo's UA stylesheet applies `overflow: hidden` to `<input>` elements. I believe that the changes are not necessary in other rendering engines because they hard-code `overflow: hidden`-like behavior for `<input>` elements, while Servo uses the actual CSS `overflow: hidden` behavior. As far as I can tell, Servo's behavior is arguably more spec-compliant, but it remains to be seen how Web compatible it is. Improves the Google results pages. Closes #13707. r? @notriddle <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13732) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Oct 13, 2016
… r=notriddle layout: Use the margin box for vertical positioning of `inline-block` fragments if `overflow` is not `visible` per CSS 2.1 § 10.8.1. Additionally, this patch reverts the change introduced in #12642 in favor of the spec-compliant behavior described above. This patch also removes the `inline_block_overflow.html` reftest introduced in #3725, as the behavior it expected contradicted CSS 2.1 (and in fact the test fails in Gecko). The changes that this patch makes to `input_selection_a.html` and `input_selection_incremental_a.html` are necessary workarounds to make the tests pass in light of the fact that Servo's UA stylesheet applies `overflow: hidden` to `<input>` elements. I believe that the changes are not necessary in other rendering engines because they hard-code `overflow: hidden`-like behavior for `<input>` elements, while Servo uses the actual CSS `overflow: hidden` behavior. As far as I can tell, Servo's behavior is arguably more spec-compliant, but it remains to be seen how Web compatible it is. Improves the Google results pages. Closes #13707. r? @notriddle <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13732) <!-- Reviewable:end -->
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
Oct 13, 2016
fragments if `overflow` is not `visible` per CSS 2.1 § 10.8.1. Additionally, this patch reverts the change introduced in servo#12642 in favor of the spec-compliant behavior described above. This patch also removes the `inline_block_overflow.html` reftest introduced in servo#3725, as the behavior it expected contradicted CSS 2.1 (and in fact the test fails in Gecko). The changes that this patch makes to `input_selection_a.html` and `input_selection_incremental_a.html` are necessary workarounds to make the tests pass in light of the fact that Servo's UA stylesheet applies `overflow: hidden` to `<input>` elements. I believe that the changes are not necessary in other rendering engines because they hard-code `overflow: hidden`-like behavior for `<input>` elements, while Servo uses the actual CSS `overflow: hidden` behavior. As far as I can tell, Servo's behavior is arguably more spec-compliant, but it remains to be seen how Web compatible it is. Improves the Google results pages. Closes servo#13707.
bors-servo
pushed a commit
that referenced
this pull request
Oct 13, 2016
… r=notriddle layout: Use the margin box for vertical positioning of `inline-block` fragments if `overflow` is not `visible` per CSS 2.1 § 10.8.1. Additionally, this patch reverts the change introduced in #12642 in favor of the spec-compliant behavior described above. This patch also removes the `inline_block_overflow.html` reftest introduced in #3725, as the behavior it expected contradicted CSS 2.1 (and in fact the test fails in Gecko). The changes that this patch makes to `input_selection_a.html` and `input_selection_incremental_a.html` are necessary workarounds to make the tests pass in light of the fact that Servo's UA stylesheet applies `overflow: hidden` to `<input>` elements. I believe that the changes are not necessary in other rendering engines because they hard-code `overflow: hidden`-like behavior for `<input>` elements, while Servo uses the actual CSS `overflow: hidden` behavior. As far as I can tell, Servo's behavior is arguably more spec-compliant, but it remains to be seen how Web compatible it is. Improves the Google results pages. Closes #13707. r? @notriddle <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13732) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an explicit height is used for inline-block fragments, the line spacing algorithm should use that for the height above the baseline, instead of the intrinsic one.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is