stylo: Use AtomicUsize to store our initial computed values #12750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
r? @Manishearth |
bholley
changed the title
| // store them as AtomicPtr, but we can't have static AtomicPtr without const | ||
| // fns, which aren't in stable Rust. | ||
| static INITIAL_VALUES_STORAGE: AtomicUsize = ATOMIC_USIZE_INIT; | ||
| unsafe fn raw_initial_values() -> *mut ComputedValues { |
There was a problem hiding this comment.
I still haven't found any reference to undefined behavior for doing what we were doing, but anyway, I've verified that using AtomicPtr with Ordering::Relaxed is only 1 instruction more in x86.
|
Well, bors doesn't peek inline comments. Feel free to r=me, or waiting for @Manishearth comments if any :) |
|
@bors-servo r+ I don't particularly like using atomicusize as a stand in for atomicptr, but AIUI they have the same semantics so it's fine. |
|
📌 Commit 8f991f7 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 6, 2016
stylo: Use AtomicUsize to store our initial computed values This addresses the discussion in https://github.com/servo/servo/pull/12725/files/b916ad0a85b88eb40d919986cdc0c6b7420a4fab#r73459385 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12750) <!-- Reviewable:end -->
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the discussion in https://github.com/servo/servo/pull/12725/files/b916ad0a85b88eb40d919986cdc0c6b7420a4fab#r73459385
This change is