Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use impl Trait syntax for Node::child_elements #12854

Merged
merged 1 commit into from Aug 14, 2016
Merged

Use impl Trait syntax for Node::child_elements #12854

merged 1 commit into from Aug 14, 2016

Conversation

nox
Copy link
Contributor

@nox nox commented Aug 13, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/node.rs, components/script/lib.rs

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 13, 2016
@jdm
Copy link
Member

jdm commented Aug 14, 2016

@bors-servo: r+
Nice.

@bors-servo
Copy link
Contributor

📌 Commit 9c8a810 has been approved by jdm

@highfive highfive assigned jdm and unassigned pcwalton Aug 14, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 14, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 9c8a810 with merge 27d082e...

bors-servo pushed a commit that referenced this pull request Aug 14, 2016
Auto merge of #12854 - nox:impl-trait, r=jdm
27d082e 
Use impl Trait syntax for Node::child_elements

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12854)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit 9c8a810 into servo:master Aug 14, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nox @highfive @jdm @bors-servo @pcwalton