Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mozjs_sys to fix the build failure on macOS Sierra #13349

Merged
merged 1 commit into from Sep 21, 2016
Merged

Update mozjs_sys to fix the build failure on macOS Sierra #13349

merged 1 commit into from Sep 21, 2016

Conversation

tetsuharuohzeki
Copy link
Contributor

@tetsuharuohzeki tetsuharuohzeki commented Sep 21, 2016 •
edited

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 21, 2016
@tetsuharuohzeki tetsuharuohzeki added P-mac Any version of MacOS A-build Related to or part of the build process labels Sep 21, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 21, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 93866d4 has been approved by Ms2ger

@highfive highfive assigned Ms2ger and unassigned wafflespeanut Sep 21, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 93866d4 with merge 236c687...

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Sep 21, 2016
bors-servo pushed a commit that referenced this pull request Sep 21, 2016
Auto merge of #13349 - saneyuki:update-mozjs-to-fix-build-on-sierra, …
236c687 
…r=Ms2ger

Update mozjs_sys to fix the build failure on macOS Sierra

- #13348
- This only fixes the failure to compile mozjs_sys. Linking problem with xcode 8 is still opened (#11846)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13349)
<!-- Reviewable:end -->
@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 21, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit 93866d4 into servo:master Sep 21, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 21, 2016
@tetsuharuohzeki tetsuharuohzeki deleted the update-mozjs-to-fix-build-on-sierra branch September 21, 2016 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
A-build Related to or part of the build process P-mac Any version of MacOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tetsuharuohzeki @Ms2ger @bors-servo @highfive @wafflespeanut