Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of text-combine-upright for stylo #14771

Merged
merged 1 commit into from
Dec 29, 2016

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Dec 29, 2016


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because it is just a trivial change for stylo only

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/inherited_text.mako.rs
  • @emilio: components/style/properties/longhand/inherited_text.mako.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 29, 2016
@cbrewster
Copy link
Contributor

r? @emilio

@highfive highfive assigned emilio and unassigned cbrewster Dec 29, 2016
@upsuper
Copy link
Contributor Author

upsuper commented Dec 29, 2016

Travis CI: No space left on device :/

@wafflespeanut
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 77bc2e0 has been approved by Wafflespeanut

@highfive highfive assigned wafflespeanut and unassigned emilio Dec 29, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 29, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 77bc2e0 with merge 49bdef9...

bors-servo pushed a commit that referenced this pull request Dec 29, 2016
Add support of text-combine-upright for stylo

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it is just a trivial change for stylo only

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14771)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

@bors-servo bors-servo merged commit 77bc2e0 into servo:master Dec 29, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants