Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Port parallel layout over to a generic "work queue" #1551

Merged
merged 1 commit into from
Jan 25, 2014

Conversation

pcwalton
Copy link
Contributor

infrastructure.

The work queue accepts abstract generic "work units", which in this case
are layout operations. The same speedups have been observed.

r? @larsbergstrom

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/634

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
  • @pcwalton, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!


//! A work queue for scheduling units of work across threads in a fork-join fashion.
//!
//! Data associated with queues is simply a pair of unsigned integers. It is expected that a
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note to self: this comment is obsolete.)

bors-servo pushed a commit that referenced this pull request Jan 25, 2014
…ergstrom

infrastructure.

The work queue accepts abstract generic "work units", which in this case
are layout operations. The same speedups have been observed.

r? @larsbergstrom
infrastructure.

The work queue accepts abstract generic "work units", which in this case
are layout operations. The same speedups have been observed.
bors-servo pushed a commit that referenced this pull request Jan 25, 2014
…ergstrom

infrastructure.

The work queue accepts abstract generic "work units", which in this case
are layout operations. The same speedups have been observed.

r? @larsbergstrom
@bors-servo bors-servo merged commit 18a2050 into servo:master Jan 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants