Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "handled for descendants" tracking for RestyleDamage. #15599

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

bholley
Copy link
Contributor

@bholley bholley commented Feb 16, 2017

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @emilio: components/style/data.rs, components/style/servo/restyle_damage.rs, components/style/traversal.rs, components/style/gecko/restyle_damage.rs, components/style/matching.rs

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 16, 2017
@bholley
Copy link
Contributor Author

bholley commented Feb 16, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 294bbb5 with merge 1863760...

bors-servo pushed a commit that referenced this pull request Feb 16, 2017
Implement "handled for descendants" tracking for RestyleDamage.

Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1340022
@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Feb 16, 2017
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Feb 16, 2017
@bholley
Copy link
Contributor Author

bholley commented Feb 16, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 7e531a4 with merge a89ce83...

bors-servo pushed a commit that referenced this pull request Feb 16, 2017
Implement "handled for descendants" tracking for RestyleDamage.

Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1340022

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15599)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
State: approved= try=True

@bholley
Copy link
Contributor Author

bholley commented Feb 16, 2017

This will need coordinated landing with the gecko-side changes, so I'm going to wait to land it until the VCS sync is working again.

@emilio
Copy link
Member

emilio commented Feb 17, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 7e531a4 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 17, 2017
@bholley
Copy link
Contributor Author

bholley commented Feb 17, 2017

@bors-servo p=10

Needs coordinated sync.

@emilio
Copy link
Member

emilio commented Feb 17, 2017

@bors-servo r- try- clean

@emilio
Copy link
Member

emilio commented Feb 17, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 7e531a4 has been approved by emilio

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 17, 2017
@bholley
Copy link
Contributor Author

bholley commented Feb 17, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit d9606a4 has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 17, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit d9606a4 with merge eb916f2...

bors-servo pushed a commit that referenced this pull request Feb 17, 2017
Implement "handled for descendants" tracking for RestyleDamage.

Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1340022

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15599)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: emilio
Pushing eb916f2 to master...

@bors-servo bors-servo merged commit d9606a4 into servo:master Feb 17, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants