Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_error is never called by Servo #15641

Open
paulrouget opened this issue Feb 19, 2017 · 2 comments
Open

load_error is never called by Servo #15641

paulrouget opened this issue Feb 19, 2017 · 2 comments

Comments

@paulrouget
Copy link
Contributor

paulrouget commented Feb 19, 2017 •
edited
Loading

This issue is part of an effort to improve Servo's embedding story. See https://github.com/paulrouget/servoshell/projects/2

WindowMethods::load_error is never called by Servo. I think it's dead code.
@paulrouget paulrouget mentioned this issue Feb 19, 2017
Closed
@paulrouget paulrouget mentioned this issue Sep 5, 2017
Open
@nox
Copy link
Contributor

nox commented Oct 8, 2017

@paulrouget Is it a bug and it should be called from somewhere, or can we remove the dead code?

@paulrouget
Copy link
Contributor Author

It should be called for any non-HTTP error. Like, if the server can't be reached, but not on a 4xx or 5xx errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nox @paulrouget