Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (clip scroll group work). #15654

Merged
merged 1 commit into from Feb 21, 2017

Conversation

glennw
Copy link
Member

@glennw glennw commented Feb 20, 2017

This shouldn't have any noticeable change on Servo, but as we land
various parts of the clip/scroll changes, keeping Servo up to date
will hopefully help catch any regressions early.


This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 20, 2017
@metajack
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 04cad59 has been approved by metajack

@highfive highfive assigned metajack and unassigned emilio Feb 20, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 20, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 04cad59 with merge 094883f...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 20, 2017
@jdm
Copy link
Member

jdm commented Feb 20, 2017

  ▶ PASS [expected FAIL] /compositing-1_dev/html/mix-blend-mode-blended-element-overflow-scroll.htm

  ▶ PASS [expected FAIL] /compositing-1_dev/html/mix-blend-mode-iframe-parent.htm

  ▶ PASS [expected FAIL] /compositing-1_dev/html/mix-blend-mode-iframe-sibling.htm

@jdm
Copy link
Member

jdm commented Feb 20, 2017

Although they're only passing on mac.

@jdm
Copy link
Member

jdm commented Feb 20, 2017

@bors-servo: try

@glennw
Copy link
Member Author

glennw commented Feb 20, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Trying commit 04cad59 with merge 92a21cb...

bors-servo pushed a commit that referenced this pull request Feb 20, 2017
Update WR (clip scroll group work).

This shouldn't have any noticeable change on Servo, but as we land
various parts of the clip/scroll changes, keeping Servo up to date
will hopefully help catch any regressions early.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15654)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Feb 20, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 20, 2017
@glennw
Copy link
Member Author

glennw commented Feb 20, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit f966112 with merge 6b6f5fe...

bors-servo pushed a commit that referenced this pull request Feb 20, 2017
Update WR (clip scroll group work).

This shouldn't have any noticeable change on Servo, but as we land
various parts of the clip/scroll changes, keeping Servo up to date
will hopefully help catch any regressions early.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15654)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
State: approved= try=True

@glennw
Copy link
Member Author

glennw commented Feb 21, 2017

@bors-servo r=metajack

Updated to include 3 new passes on mac. They still fail on Linux due to an apparent rounding issue in the rasterizer.

@bors-servo
Copy link
Contributor

📌 Commit f966112 has been approved by metajack

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 21, 2017
@glennw
Copy link
Member Author

glennw commented Feb 21, 2017

@bors-servo try- r=metajack clean force

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

📌 Commit f966112 has been approved by metajack

This shouldn't have any noticeable change on Servo, but as we land
various parts of the clip/scroll changes, keeping Servo up to date
will hopefully help catch any regressions early.
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 21, 2017
@glennw
Copy link
Member Author

glennw commented Feb 21, 2017

@bors-servo r=metajack

1 similar comment
@glennw
Copy link
Member Author

glennw commented Feb 21, 2017

@bors-servo r=metajack

@bors-servo
Copy link
Contributor

📌 Commit b1e91a9 has been approved by metajack

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 21, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit b1e91a9 with merge b5d8e8b...

bors-servo pushed a commit that referenced this pull request Feb 21, 2017
Update WR (clip scroll group work).

This shouldn't have any noticeable change on Servo, but as we land
various parts of the clip/scroll changes, keeping Servo up to date
will hopefully help catch any regressions early.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15654)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: metajack
Pushing b5d8e8b to master...

@bors-servo bors-servo merged commit b1e91a9 into servo:master Feb 21, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants