Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1341083: Implement dynamic restyling for display: contents. #15736

Merged
merged 1 commit into from Feb 25, 2017
Merged

Bug 1341083: Implement dynamic restyling for display: contents. #15736

merged 1 commit into from Feb 25, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Feb 25, 2017 •
edited by larsbergstrom

Reviewed upstream by @heycam

cc @bholley, didn't end up renaming the layout_parent thing, because it made the cascade way more verbose (and difficult to understand IMO) unnecessarily, and you said you were ok-ish with it.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/values/computed/mod.rs, components/style/animation.rs, components/style/viewport.rs, components/style/matching.rs, components/style/properties/properties.mako.rs, components/style/gecko/media_queries.rs, components/style/stylist.rs

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 25, 2017
@emilio
Copy link
Member Author

emilio commented Feb 25, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit 0a2556a has been approved by heycam

@highfive highfive assigned heycam and unassigned mbrubeck Feb 25, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 25, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 0a2556a with merge 8403fd6...

bors-servo pushed a commit that referenced this pull request Feb 25, 2017
Auto merge of #15736 - servo:display-contents, r=heycam
8403fd6 
Bug 1341083: Implement dynamic restyling for display: contents.

Reviewed upstream by @heycam

cc @bholley, didn't end up renaming the `layout_parent` thing, because it made the cascade way more verbose (and difficult to understand IMO) unnecessarily, and you said you were ok-ish with it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15736)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 25, 2017
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 25, 2017
@emilio
Copy link
Member Author

emilio commented Feb 25, 2017

@bors-servo r=heycam

  • Added missing default-field in the media-query code

@bors-servo
Copy link
Contributor

📌 Commit 39cd718 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 25, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 39cd718 with merge 8e4b9d7...

bors-servo pushed a commit that referenced this pull request Feb 25, 2017
Auto merge of #15736 - servo:display-contents, r=heycam
8e4b9d7 
Bug 1341083: Implement dynamic restyling for display: contents.

Reviewed upstream by @heycam

cc @bholley, didn't end up renaming the `layout_parent` thing, because it made the cascade way more verbose (and difficult to understand IMO) unnecessarily, and you said you were ok-ish with it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15736)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 25, 2017
@emilio
Bug 1341083: Implement dynamic restyling for display: contents. r=heycam
6875c65 
MozReview-Commit-ID: KimTU2j4V4p
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Feb 25, 2017
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 25, 2017
@emilio
Copy link
Member Author

emilio commented Feb 25, 2017 •
edited

@bors-servo retry

  • Unit tests

@emilio
Copy link
Member Author

emilio commented Feb 25, 2017

@bors-servo r=heycam

@bors-servo
Copy link
Contributor

📌 Commit 6875c65 has been approved by heycam

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 25, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 6875c65 with merge b77140a...

bors-servo pushed a commit that referenced this pull request Feb 25, 2017
Auto merge of #15736 - servo:display-contents, r=heycam
b77140a 
Bug 1341083: Implement dynamic restyling for display: contents.

Reviewed upstream by @heycam

cc @bholley, didn't end up renaming the `layout_parent` thing, because it made the cascade way more verbose (and difficult to understand IMO) unnecessarily, and you said you were ok-ish with it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15736)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

@bors-servo
Copy link
Contributor

📌 Commit 6875c65 has been approved by heycam

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: heycam
Pushing b77140a to master...

@bors-servo bors-servo merged commit 6875c65 into master Feb 25, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 25, 2017
@SimonSapin SimonSapin deleted the display-contents branch March 13, 2017 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emilio @highfive @bors-servo @mbrubeck @heycam