Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more XUL properties #15817

Merged
merged 1 commit into from Mar 4, 2017
Merged

Support more XUL properties #15817

merged 1 commit into from Mar 4, 2017

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Mar 4, 2017 •
edited

This change is Reviewable

@highfive
Copy link

highfive commented Mar 4, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/xul.mako.rs
  • @emilio: components/style/properties/longhand/xul.mako.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 4, 2017
@highfive
Copy link

highfive commented Mar 4, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@bholley
Copy link
Contributor

bholley commented Mar 4, 2017

@bors-servo delegate+

@bors-servo
Copy link
Contributor

✌️ @Manishearth can now approve this pull request

@Manishearth
Copy link
Member Author

@bors-servo r=bholley

@bors-servo
Copy link
Contributor

📌 Commit 58d32b2 has been approved by bholley

@highfive highfive assigned bholley and unassigned heycam Mar 4, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 4, 2017
bors-servo pushed a commit that referenced this pull request Mar 4, 2017
Auto merge of #15817 - Manishearth:xul, r=bholley
78210c3 
Support more XUL properties

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15817)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 58d32b2 with merge 78210c3...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: bholley
Pushing 78210c3 to master...

@bors-servo bors-servo merged commit 58d32b2 into servo:master Mar 4, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 4, 2017
@Manishearth Manishearth deleted the xul branch March 4, 2017 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
None yet
Projects
None yet
Milestone
Stylo: Style system mochitests
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Manishearth @highfive @bholley @bors-servo @upsuper @heycam