remove unused use statements in mako helpers
#16121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are no longer needed, according to `./mach build -d` and grep.
|
|
highfive
added
the
S-awaiting-review
|
@bors-servo r+ |
|
📌 Commit 5f49e38 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Mar 24, 2017
remove unused `use` statements in mako helpers These are no longer needed, according to `./mach build -d` and grep. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because compilation is sufficient <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16121) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt1 |
highfive
added
S-tests-failed
|
@bors-servo retry #14323 |
bors-servo
pushed a commit
that referenced
this pull request
Mar 25, 2017
remove unused `use` statements in mako helpers These are no longer needed, according to `./mach build -d` and grep. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because compilation is sufficient <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16121) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
💔 Test failed - mac-rel-wpt1 |
highfive
added
S-tests-failed
|
Meh, same thing. @bors-servo retry |
|
⚡ Previous build results for android, arm64, linux-dev, mac-dev-unit, windows-msvc-dev are reusable. Rebuilding only arm32, linux-rel-css, linux-rel-wpt, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2... |
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are no longer needed, according to
./mach build -dand grep../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is