style: Add <keyword>::from_ident helper to avoid tokenizing the same value multiple times. #16141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value multiple times.
highfive
added
the
S-awaiting-review
|
r? @upsuper (or anyone else really) |
4 tasks
|
@bors-servo r+ |
|
📌 Commit a5436e9 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Mar 26, 2017
style: Add <keyword>::from_ident helper to avoid tokenizing the same value multiple times. We can use this to avoid tokenizing multiple times in some places, like #16127. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16141) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-css |
highfive
added
S-tests-failed
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Mar 26, 2017
style: Add <keyword>::from_ident helper to avoid tokenizing the same value multiple times. We can use this to avoid tokenizing multiple times in some places, like #16127. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16141) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
💔 Test failed - linux-rel-css |
highfive
added
S-tests-failed
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Mar 27, 2017
style: Add <keyword>::from_ident helper to avoid tokenizing the same value multiple times. We can use this to avoid tokenizing multiple times in some places, like #16127. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16141) <!-- Reviewable:end -->
highfive
added
the
S-awaiting-merge
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use this to avoid tokenizing multiple times in some places, like #16127.
This change is