Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump required rayon version to 0.7 #16303

Merged
merged 2 commits into from May 9, 2017
Merged

bump required rayon version to 0.7 #16303

merged 2 commits into from May 9, 2017

Conversation

froydnj
Copy link
Contributor

@froydnj froydnj commented Apr 7, 2017 •
edited by larsbergstrom

...and bring jpeg-decoder along for the ride. Minor tweaks were necessary because of rayon API changes.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable

@highfive
Copy link

highfive commented Apr 7, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/scoped_tls.rs, components/style/gecko/global_style_data.rs
  • @emilio: components/style/Cargo.toml, components/style/scoped_tls.rs, components/layout/Cargo.toml, components/style/gecko/global_style_data.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 7, 2017
@jdm
Copy link
Member

jdm commented Apr 7, 2017

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 4d53ff9 has been approved by jdm

@highfive highfive assigned jdm and unassigned mbrubeck Apr 7, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 7, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 4d53ff9 with merge 8dd26c7...

bors-servo pushed a commit that referenced this pull request Apr 7, 2017
Auto merge of #16303 - froydnj:rayon-version-bump, r=jdm
8dd26c7 
bump required rayon version to 0.7

...and bring jpeg-decoder along for the ride.  Minor tweaks were necessary because of rayon API changes.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16303)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 7, 2017
@jdm
Copy link
Member

jdm commented Apr 7, 2017

@bors-servo: try
I am always concerned by a rash of new timeouts.

@jdm
Copy link
Member

jdm commented Apr 7, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Trying commit 4d53ff9 with merge 046d63d...

bors-servo pushed a commit that referenced this pull request Apr 7, 2017
Auto merge of #16303 - froydnj:rayon-version-bump, r=<try>
046d63d 
bump required rayon version to 0.7

...and bring jpeg-decoder along for the ride.  Minor tweaks were necessary because of rayon API changes.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16303)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt2

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 7, 2017
@froydnj
Copy link
Contributor Author

froydnj commented Apr 7, 2017

Well, that's no fun.

@froydnj
Copy link
Contributor Author

froydnj commented Apr 7, 2017

Different set of failures this time, though?

@jdm
Copy link
Member

jdm commented Apr 7, 2017

Looking more carefully, I I don't think there's anything new going on. This is ok.
@bors-servo: try- retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 4d53ff9 with merge bed1423...

bors-servo pushed a commit that referenced this pull request Apr 7, 2017
Auto merge of #16303 - froydnj:rayon-version-bump, r=jdm
bed1423 
bump required rayon version to 0.7

...and bring jpeg-decoder along for the ride.  Minor tweaks were necessary because of rayon API changes.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16303)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 7, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 7, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit f51ea4a with merge f756847...

bors-servo pushed a commit that referenced this pull request May 8, 2017
Auto merge of #16303 - froydnj:rayon-version-bump, r=jdm
f756847 
bump required rayon version to 0.7

...and bring jpeg-decoder along for the ride.  Minor tweaks were necessary because of rayon API changes.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16303)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 8, 2017
@jdm
Copy link
Member

jdm commented May 8, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit f51ea4a with merge 045ece3...

bors-servo pushed a commit that referenced this pull request May 8, 2017
Auto merge of #16303 - froydnj:rayon-version-bump, r=jdm
045ece3 
bump required rayon version to 0.7

...and bring jpeg-decoder along for the ride.  Minor tweaks were necessary because of rayon API changes.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16303)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels May 8, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - android

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 8, 2017
@jdm
Copy link
Member

jdm commented May 8, 2017

@bors-servo: retry

  • cross3 is broken

@bors-servo
Copy link
Contributor

⌛ Testing commit f51ea4a with merge d3d3fc4...

bors-servo pushed a commit that referenced this pull request May 9, 2017
Auto merge of #16303 - froydnj:rayon-version-bump, r=jdm
d3d3fc4 
bump required rayon version to 0.7

...and bring jpeg-decoder along for the ride.  Minor tweaks were necessary because of rayon API changes.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16303)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels May 9, 2017
@bors-servo
Copy link
Contributor

💔 Test failed - android

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 9, 2017
@jdm
Copy link
Member

jdm commented May 9, 2017

@bors-servo: retry

  • cross3 is broken

@bors-servo
Copy link
Contributor

⌛ Testing commit f51ea4a with merge fc3a7d0...

bors-servo pushed a commit that referenced this pull request May 9, 2017
Auto merge of #16303 - froydnj:rayon-version-bump, r=jdm
fc3a7d0 
bump required rayon version to 0.7

...and bring jpeg-decoder along for the ride.  Minor tweaks were necessary because of rayon API changes.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16303)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels May 9, 2017
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing fc3a7d0 to master...

@bors-servo bors-servo merged commit f51ea4a into servo:master May 9, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 9, 2017
bors-servo pushed a commit to servo/webrender that referenced this pull request May 9, 2017
Auto merge of #1202 - nical:rayon, r=kvark
7f9051c 
Use rayon's thread pool.

cf. issue #1178.

Rayon's thread pool implementation is a lot better than the one provided by the threadpool crate, and comes with a lot of very useful additional features. The spawn_async functionality which we need is currently behind the unstable feature flag. Note that stylo is also using rayon with the unstable feature flag and is bumping to version 0.7 in servo/servo#16303.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1202)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@froydnj @highfive @jdm @bors-servo @mbrubeck @emilio @Manishearth @glennw @stshine @bholley